Disable enhanced metric by setting an environment variable DD_SUBMIT_ENHANCED_METRICS to false#769
Open
perzycharles wants to merge 4 commits intomasterfrom
Open
Disable enhanced metric by setting an environment variable DD_SUBMIT_ENHANCED_METRICS to false#769perzycharles wants to merge 4 commits intomasterfrom
DD_SUBMIT_ENHANCED_METRICS to false#769perzycharles wants to merge 4 commits intomasterfrom
Conversation
…v variable DD_SUBMIT_ENHANCED_METRICS
RaphaelAllier
approved these changes
Apr 9, 2024
Contributor
|
Wait. I think this variable is a already being used? Is the plan to overload the old env var with this enablement? |
kimi-p
requested changes
Apr 9, 2024
Contributor
kimi-p
left a comment
kimi-p
left a comment
There was a problem hiding this comment.
DD_SUBMIT_ENHANCED_METRICS is already used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the forwarder has another function log group as a trigger, enhanced lambda metric of another function would be generated, which is confusing because this will cause the other function to appear in the Serverless page.
What does this PR do?
This PR would allow customer to disable enhanced metric by simply setting an environment variable
DD_SUBMIT_ENHANCED_METRICStofalseMotivation
Jira issues CLOUDS-4535/CLOUDS-4529
Testing Guidelines
Additional Notes
Types of changes
Check all that apply